-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fixing reference to UIWindow #2246
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dansiegel
approved these changes
Apr 11, 2024
@Mergifyio backport release/stable/4.1 |
✅ Backports have been created
|
If not pressed for time, then this could probably be adjusted to use |
jeromelaban
approved these changes
Apr 11, 2024
nickrandolph
force-pushed
the
dev/nr/nativewindow
branch
from
April 11, 2024 14:17
4b802eb
to
a106876
Compare
agneszitte
approved these changes
Apr 11, 2024
nickrandolph
commented
Apr 13, 2024
7 tasks
dansiegel
added a commit
that referenced
this pull request
Apr 17, 2024
….1/pr-2246 chore: Fixing reference to UIWindow (backport #2246)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #2240
PR Type
What kind of change does this PR introduce?
What is the current behavior?
UIWindow not found using the old _window field.
What is the new behavior?
v5.2 of Uno adds multi-window support along with refactoring inner logic for Window management.
the internal NativeWindow property now returns the UIWindow required for Maui Embedding
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.Other information
Internal Issue (If applicable):