Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fixing reference to UIWindow #2246

Merged
merged 10 commits into from
Apr 17, 2024
Merged

chore: Fixing reference to UIWindow #2246

merged 10 commits into from
Apr 17, 2024

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): closes #2240

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

UIWindow not found using the old _window field.

What is the new behavior?

v5.2 of Uno adds multi-window support along with refactoring inner logic for Window management.
the internal NativeWindow property now returns the UIWindow required for Maui Embedding

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph enabled auto-merge April 11, 2024 03:28
@nickrandolph
Copy link
Contributor Author

@Mergifyio backport release/stable/4.1

Copy link

mergify bot commented Apr 11, 2024

backport release/stable/4.1

✅ Backports have been created

@MartinZikmund
Copy link
Member

If not pressed for time, then this could probably be adjusted to use WindowHelper.GetNativeWindow and ApplicationHelper.Windows see docs here unoplatform/uno#16223

@dansiegel dansiegel disabled auto-merge April 16, 2024 23:39
@dansiegel dansiegel enabled auto-merge April 17, 2024 15:02
@dansiegel dansiegel merged commit 39dabb4 into main Apr 17, 2024
15 of 16 checks passed
@dansiegel dansiegel deleted the dev/nr/nativewindow branch April 17, 2024 15:24
dansiegel added a commit that referenced this pull request Apr 17, 2024
….1/pr-2246

chore: Fixing reference to UIWindow (backport #2246)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS][MauiEmbedding] Uno.Extensions.Maui.MauiEmbeddingException
5 participants