Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Configuration information not passed to Authentication providers by name (backport #2198) #2202

Merged

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 15, 2024

GitHub Issue (If applicable): closes #2193

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Where there are multiple configurations for a given type, or they're referenced by name, the configuration doesn't return valid information

What is the new behavior?

Configuration sections are correctly registered by name

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):


This is an automatic backport of pull request #2198 done by [Mergify](https://mergify.com).

…ml#5689

(cherry picked from commit 76a69ad)

# Conflicts:
#	testing/TestHarness/Directory.Packages.props
(cherry picked from commit 4a25852)
Copy link
Author

mergify bot commented Mar 15, 2024

Cherry-pick of 76a69ad has failed:

On branch mergify/bp/release/stable/4.0/pr-2198
Your branch is up to date with 'origin/release/stable/4.0'.

You are currently cherry-picking commit 76a69ad02.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   testing/TestHarness/TestHarness.Windows/TestHarness.Windows.csproj

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   testing/TestHarness/Directory.Packages.props

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@nickrandolph nickrandolph enabled auto-merge March 15, 2024 04:18
@nickrandolph nickrandolph merged commit f154d50 into release/stable/4.0 Mar 15, 2024
13 checks passed
@nickrandolph nickrandolph deleted the mergify/bp/release/stable/4.0/pr-2198 branch March 15, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant