Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding platform check before invoking dllimport method #2186

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): related to unoplatform/uno#15635

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Dllimported method GetCurrentPackageFullName is invoked on all platforms other than WASM. It should only be invoked on Windows

What is the new behavior?

Platform check ensures GetCurrentPackageFullName is only called on Windows

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

Co-authored-by: Jérôme Laban <jerome@platform.uno>
@nickrandolph nickrandolph merged commit 024d12b into main Mar 4, 2024
15 of 16 checks passed
@nickrandolph nickrandolph deleted the dev/nr/platformcheck branch March 4, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants