Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding support for unpackaged Windows applications #2179

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): closes #2133, #1369, #2055, #1370

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Unpackaged (Windows) applications can't make used of applicationdata, so IStorage and localization services don't work

What is the new behavior?

For unpackaged applications, the local path to the executing assembly is used for packaged files. A settings implementation has been added to support read/write settings where ApplicationData.LocalSettings doesn't work for unpackaged applications.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph merged commit 51c9c1e into main Feb 23, 2024
15 of 16 checks passed
@nickrandolph nickrandolph deleted the dev/nr/unpackaged branch February 23, 2024 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LocalizationService does not set a culture in Windows (Unpackaged) Head
2 participants