fix: Correcting browser history and adding back button integration #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… registered with configuration)
…tead of pushing state
aad384c to
d0d0936
Compare
b18164a to
fd4dc2e
Compare
jeromelaban
reviewed
Feb 6, 2024
jeromelaban
approved these changes
Feb 6, 2024
|
@mergify backport stable/release/4.0 |
❌ No backport have been created
GitHub error: |
|
@mergify backport release/stable/4.0 |
✅ Backports have been created
|
nickrandolph
added a commit
that referenced
this pull request
Feb 6, 2024
….0/pr-2161 fix: Correcting browser history and adding back button integration (backport #2161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): fixes #1998, #2038
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No support for back button to drive navigation
Updating address bar adds to browser history, which is meaningless if use navigates back within the app (which will continue to add items instead of removing them)
What is the new behavior?
Address bar support is consistent with the SystemNavigationManager implementation - single item that is updated if there is somewhere to navigate back to
Added back button integration for browser
Both address bar updating and back button usage can be controlled using the NavigationConfiguration class that can be set in appsettings.json
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):