Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding ClosableNavigator to close dialog/flyout when attempting to navigate to unsupported route #2128

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Jan 3, 2024

GitHub Issue (If applicable): closes #1394

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

No easy way to navigate from inside a dialog/flyout to a route in the main window of the application. This should close the dialog/flyout

What is the new behavior?

If the route can't be navigated to within the dialog (eg the route isn't part of the routemap for the route already open in the dialog/route), the navigation request is forwarded to the navigator that initially opened the dialog/flyout. The Dialog/Flyout is also closed

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@nickrandolph nickrandolph marked this pull request as ready for review January 4, 2024 04:36
@nickrandolph nickrandolph enabled auto-merge January 4, 2024 04:48
@nickrandolph nickrandolph merged commit 996a0d0 into main Jan 4, 2024
15 of 16 checks passed
@nickrandolph nickrandolph deleted the dev/nr/closedialog branch January 4, 2024 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Navigation] Close dialog when navigating
2 participants