Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [MVUX] Enforce code analysis rules #2082

Merged
merged 2 commits into from
Apr 1, 2024
Merged

chore: [MVUX] Enforce code analysis rules #2082

merged 2 commits into from
Apr 1, 2024

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Nov 30, 2023

Based on #2080 which needs to be merged first

Other

Make MVUX compliant with CA2007 and CA2016

What is the current behavior?

  • CA2007: Possible irrelevant thread swicthing
  • CA2016: Might forget CT propagation

What is the new behavior?

🙃

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb marked this pull request as draft November 30, 2023 23:02
@dr1rrb dr1rrb changed the title Code analysis chore: [MVUX] Enforce code analysis rules Nov 30, 2023
@dr1rrb dr1rrb marked this pull request as ready for review December 22, 2023 16:14
@dr1rrb
Copy link
Member Author

dr1rrb commented Apr 1, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dr1rrb dr1rrb merged commit 9171c19 into main Apr 1, 2024
15 of 16 checks passed
@dr1rrb dr1rrb deleted the dev/dr/caRules branch April 1, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants