-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Adjust namespaces related to latest Uno packages #206
refactor: Adjust namespaces related to latest Uno packages #206
Conversation
746596f
to
cea9b44
Compare
PR Ready for review, BUT DO NOT MERGE. Tests are still in progress for some platforms |
cea9b44
to
588cc0c
Compare
...xtensions.Templates/content/unoapp-extensions/MyExtensionsApp.Shared/Views/ProductsPage.xaml
Show resolved
Hide resolved
src/extensions/ExtensionsSampleApp/ExtensionsSampleApp.Shared/Views/Twitter/TwitterPage.xaml
Outdated
Show resolved
Hide resolved
...ons.Templates/content/unoapp-extensions/MyExtensionsApp.Shared/Views/ProductDetailsPage.xaml
Outdated
Show resolved
Hide resolved
src/extensions/ExtensionsSampleApp/ExtensionsSampleApp.Shared/UnoCommerce/CommerceHomePage.xaml
Outdated
Show resolved
Hide resolved
src/extensions/ExtensionsSampleApp/ExtensionsSampleApp.Shared/UnoCommerce/ProductsPage.xaml
Outdated
Show resolved
Hide resolved
src/extensions/ExtensionsSampleApp/ExtensionsSampleApp.Shared/Views/NavigationViewPage.xaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly just fix: src\Uno.Extensions.Templates\content\unoapp-extensions\MyExtensionsApp.Shared\Views\ProductsPage.xaml
nice to have: there are few more formatting issues i didnt want to mention anymore
if you are doing global changes, at least give some attention to the 1-2 lines before and after
588cc0c
to
c0452e6
Compare
c0452e6
to
22ea7f9
Compare
22ea7f9
to
9c018df
Compare
changes done, thank you! |
PR Type
What kind of change does this PR introduce?
What is the new behavior?
Adjust namespaces related to latest Uno packages
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.