Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Adjust namespaces related to latest Uno packages #206

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

agneszitte
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the new behavior?

Adjust namespaces related to latest Uno packages

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@agneszitte agneszitte force-pushed the dev/agzi/AdjustNamespacesWithLatestUnoPackages branch from 746596f to cea9b44 Compare December 3, 2021 03:06
@agneszitte
Copy link
Contributor Author

agneszitte commented Dec 3, 2021

PR Ready for review, BUT DO NOT MERGE. Tests are still in progress for some platforms

@agneszitte agneszitte added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2021
@agneszitte agneszitte force-pushed the dev/agzi/AdjustNamespacesWithLatestUnoPackages branch from cea9b44 to 588cc0c Compare December 3, 2021 03:17
Copy link
Contributor

@Xiaoy312 Xiaoy312 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly just fix: src\Uno.Extensions.Templates\content\unoapp-extensions\MyExtensionsApp.Shared\Views\ProductsPage.xaml
nice to have: there are few more formatting issues i didnt want to mention anymore
if you are doing global changes, at least give some attention to the 1-2 lines before and after

@agneszitte agneszitte force-pushed the dev/agzi/AdjustNamespacesWithLatestUnoPackages branch from 588cc0c to c0452e6 Compare December 3, 2021 17:02
@Xiaoy312 Xiaoy312 self-requested a review December 3, 2021 17:17
@agneszitte agneszitte force-pushed the dev/agzi/AdjustNamespacesWithLatestUnoPackages branch from c0452e6 to 22ea7f9 Compare December 3, 2021 17:59
@agneszitte agneszitte force-pushed the dev/agzi/AdjustNamespacesWithLatestUnoPackages branch from 22ea7f9 to 9c018df Compare December 3, 2021 18:05
@agneszitte agneszitte removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2021
@agneszitte
Copy link
Contributor Author

mostly just fix: src\Uno.Extensions.Templates\content\unoapp-extensions\MyExtensionsApp.Shared\Views\ProductsPage.xaml nice to have: there are few more formatting issues i didnt want to mention anymore if you are doing global changes, at least give some attention to the 1-2 lines before and after

changes done, thank you!

@agneszitte agneszitte enabled auto-merge December 3, 2021 18:54
@agneszitte agneszitte merged commit 914f74f into main Dec 3, 2021
@agneszitte agneszitte deleted the dev/agzi/AdjustNamespacesWithLatestUnoPackages branch December 3, 2021 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants