Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding playground targets #1964

Merged
merged 6 commits into from
Nov 13, 2023
Merged

feat: Adding playground targets #1964

merged 6 commits into from
Nov 13, 2023

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Oct 16, 2023 •
edited
Loading

closes #1642

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

Playground only has Windows target

What is the new behavior?

Playground has mobile, wasm and gtk targets

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1964.eastus2.azurestaticapps.net

@nickrandolph nickrandolph force-pushed the dev/nr/playgroundupdate branch from e3137ae to 591b1c0 Compare October 16, 2023 15:01
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1964.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1964.eastus2.azurestaticapps.net

@nickrandolph nickrandolph force-pushed the dev/nr/playgroundupdate branch 2 times, most recently from 028d689 to d60b9a1 Compare October 23, 2023 08:03
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1964.eastus2.azurestaticapps.net

1 similar comment
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1964.eastus2.azurestaticapps.net

@nickrandolph nickrandolph force-pushed the dev/nr/playgroundupdate branch from 2525d23 to f29901f Compare October 27, 2023 16:01
@nickrandolph nickrandolph marked this pull request as ready for review October 27, 2023 16:01
@dansiegel dansiegel enabled auto-merge October 27, 2023 16:06
@nickrandolph nickrandolph force-pushed the dev/nr/playgroundupdate branch from f29901f to d7f5efb Compare November 13, 2023 05:20
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1964.eastus2.azurestaticapps.net

@nickrandolph nickrandolph force-pushed the dev/nr/playgroundupdate branch from d7f5efb to ec5a87a Compare November 13, 2023 05:50
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1964.eastus2.azurestaticapps.net

@nickrandolph nickrandolph force-pushed the dev/nr/playgroundupdate branch from ec5a87a to 3cc82aa Compare November 13, 2023 06:06
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1964.eastus2.azurestaticapps.net

@nickrandolph nickrandolph force-pushed the dev/nr/playgroundupdate branch from 3cc82aa to fa660d4 Compare November 13, 2023 06:17
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1964.eastus2.azurestaticapps.net

@dansiegel dansiegel merged commit bebfcdd into main Nov 13, 2023
14 checks passed
@dansiegel dansiegel deleted the dev/nr/playgroundupdate branch November 13, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Playground sample
2 participants
@nickrandolph @dansiegel