Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose created Maui view on the Maui Host #1803

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

dansiegel
Copy link
Contributor

GitHub Issue (If applicable): #

  • n/a

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

The Maui content is silently created by the MauiHost and is not exposed

What is the new behavior?

The created VisualElement is now exposed through the Content property of the MauiHost. A new MauiContentCreated event has been added which can additionally be hooked onto to register a callback that should execute when the view is created.

cc: @dotMorten

@dansiegel dansiegel requested a review from nickrandolph August 23, 2023 16:51
@github-actions
Copy link

github-actions bot commented Aug 23, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1803.eastus2.azurestaticapps.net

@dansiegel dansiegel force-pushed the dev/ds/expose-maui-content branch from face182 to d5af855 Compare August 24, 2023 16:13
@nickrandolph nickrandolph enabled auto-merge August 24, 2023 16:16
@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1803.eastus2.azurestaticapps.net

@github-actions
Copy link

github-actions bot commented Aug 24, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-moss-0c5b8040f-1803.eastus2.azurestaticapps.net

@nickrandolph nickrandolph merged commit 0259182 into main Aug 24, 2023
@nickrandolph nickrandolph deleted the dev/ds/expose-maui-content branch August 24, 2023 18:17
@nickrandolph
Copy link
Contributor

@mergify backport legacy/2x

@mergify
Copy link

mergify bot commented Aug 25, 2023

backport legacy/2x

✅ Backports have been created

@nickrandolph
Copy link
Contributor

@mergify backport release/stable/2.5

@mergify
Copy link

mergify bot commented Aug 25, 2023

backport release/stable/2.5

✅ Backports have been created

nickrandolph added a commit that referenced this pull request Aug 25, 2023
….5/pr-1803

Expose created Maui view on the Maui Host (backport #1803)
nickrandolph added a commit that referenced this pull request Aug 25, 2023
Expose created Maui view on the Maui Host (backport #1803)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants