Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding notes on implementation #1789

Merged
merged 11 commits into from
Aug 21, 2023
Merged

Conversation

dansiegel
Copy link
Contributor

GitHub Issue (If applicable): #

  • closes unoplatform/uno.extensions-private#101
  • closes unoplatform/uno.extensions-private#104

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Maui Embedding remains decoupled from Maui

What is the new behavior?

Maui Embedding makes use of the Maui host applications and initializes a "Current" instance of them so that references to the concrete types will not cause fatal exceptions that prevent some controls from rendering.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@dansiegel dansiegel marked this pull request as ready for review August 21, 2023 15:41
@dansiegel dansiegel enabled auto-merge August 21, 2023 15:42
@dansiegel dansiegel merged commit 201a3e5 into main Aug 21, 2023
@dansiegel dansiegel deleted the dev/ds/maui-reference-notes branch August 21, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants