Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix projected pagination cycling #1782

Merged
merged 1 commit into from
Aug 17, 2023
Merged

fix: Fix projected pagination cycling #1782

merged 1 commit into from
Aug 17, 2023

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Aug 15, 2023

closes #1757

Bugfix

Pagination with parameter can produce empty TokenSet for which comparison is not valid.

What is the current behavior?

On first page an empty token set is return, causing the ListView to not wait properly for pagination result, driving to infinitely re-request more items.

What is the new behavior?

Empty TokenSet are always consider as "lower than" any non empty token set.

PR Checklist

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb merged commit 520f15e into main Aug 17, 2023
@dr1rrb dr1rrb deleted the dev/dr/pageWCur branch August 17, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with cursor pagination with parameter
2 participants