Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix thread-safety of PropertySelectorGenerator #1759

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #1755

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@Youssef1313 Youssef1313 requested a review from dr1rrb August 11, 2023 10:27
@Youssef1313 Youssef1313 merged commit 8e2a23b into unoplatform:main Aug 11, 2023
@Youssef1313 Youssef1313 deleted the thread-safety-gen branch August 11, 2023 21:12
@nickrandolph
Copy link
Contributor

@mergify backport legacy/2x

@mergify
Copy link

mergify bot commented Aug 14, 2023

backport legacy/2x

✅ Backports have been created

@weitzhandler
Copy link
Member

Is this included in 3.0.0-dev.2163? Because the issue still persists in that version.

@Youssef1313
Copy link
Member Author

The fix should be in that version :'(

Do we have a way to get a stack trace or something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PropertySelectorGenerator crashes with ArgumentException
4 participants