fix: FeedView not initializing properly if not visible on first load #1756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1666
Bugfix
FeedView not initializing properly is not visible on first load
What is the current behavior?
FeedView
subscribes to itsSource
on loaded, no matter if the template has yet been applied or not. This drives theFeedView
to invoke someGoToState
which does nothing, and will not do it again when template is being applied.What is the new behavior?
We wait to have both being loaded and have a template applied before subscribing to the
Source
.Note: This also make sure to not load some data if useless, which is the expected default behavior so far.
PR Checklist
Screenshots Compare Test Run
results.