Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensuring Region.Logger is set before navigation proceeds #1733

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): #1732

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Region.Logger isn't set if startup takes too long

What is the new behavior?

Region.Logger is always set before nav takes place

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

Copy link
Member

@Youssef1313 Youssef1313 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment on TCS usage, but other than that LGTM

@nickrandolph nickrandolph enabled auto-merge August 3, 2023 09:30
@nickrandolph nickrandolph merged commit 918b276 into main Aug 3, 2023
@nickrandolph nickrandolph deleted the dev/nr/issue1732 branch August 3, 2023 10:59
@nickrandolph
Copy link
Contributor Author

@Mergifyio backport legacy/2x

@mergify
Copy link

mergify bot commented Aug 3, 2023

backport legacy/2x

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants