Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adding net7.0 support for maui package #1704

Merged
merged 3 commits into from
Jul 28, 2023
Merged

fix: Adding net7.0 support for maui package #1704

merged 3 commits into from
Jul 28, 2023

Conversation

nickrandolph
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Uno.Extensions.Maui can't (easily) be added to a library that includes .net7.0 tfm

What is the new behavior?

Uno.Extensions.Maui can be aded to a regular uno class library without issues

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph requested a review from dansiegel July 27, 2023 13:08
@nickrandolph nickrandolph enabled auto-merge July 28, 2023 03:44
dansiegel
dansiegel approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@dansiegel dansiegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis that I will make changes next week

src/Uno.Extensions.Maui.UI/build/Package.props Show resolved Hide resolved
@nickrandolph nickrandolph merged commit b890390 into main Jul 28, 2023
@nickrandolph nickrandolph deleted the dev/nr/nugetupdate branch July 28, 2023 05:45
@nickrandolph
Copy link
Contributor Author

@Mergifyio backport legacy/2x

@mergify
Copy link

mergify bot commented Jul 28, 2023 •
edited
Loading

backport legacy/2x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Jul 28, 2023
Merged
nickrandolph added a commit that referenced this pull request Jul 28, 2023
@nickrandolph
Merge pull request #1706 from unoplatform/mergify/bp/legacy/2x/pr-1704
0c9e50f 
fix: Adding net7.0 support for maui package (backport #1704)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dansiegel dansiegel dansiegel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickrandolph @dansiegel