Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only including using when on supported tfm #1702

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): #https://github.com/unoplatform/uno.extensions-private/issues/79

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Global usings for unsupported tfms (eg net7.0) will cause a build error

What is the new behavior?

Only add global usings for ios, android and winui

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph enabled auto-merge July 27, 2023 08:45
@nickrandolph nickrandolph merged commit 162552b into main Jul 27, 2023
@nickrandolph nickrandolph deleted the dev/nr/nugetupdate branch July 27, 2023 09:36
@nickrandolph
Copy link
Contributor Author

@Mergifyio backport legacy/2x

@mergify
Copy link

mergify bot commented Jul 27, 2023

backport legacy/2x

✅ Backports have been created

nickrandolph added a commit that referenced this pull request Jul 27, 2023
fix: Only including using when on supported tfm (backport #1702)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants