Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent redirect for data when navigating back with data #1680

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): #1652

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

If data is provided when using NavigateBackWithResultAsync, the data will be used to determine navigation path, instead of going back

What is the new behavior?

Redirection isn't done based on data if the request is not empty (which includes if navigating back)

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph enabled auto-merge July 26, 2023 04:04
@nickrandolph nickrandolph merged commit e148dc2 into main Jul 26, 2023
@nickrandolph nickrandolph deleted the dev/nr/issue1652 branch July 26, 2023 04:20
@nickrandolph
Copy link
Contributor Author

@Mergifyio backport legacy/2x

@mergify
Copy link

mergify bot commented Aug 4, 2023

backport legacy/2x

✅ Backports have been created

nickrandolph added a commit that referenced this pull request Aug 11, 2023
fix: Prevent redirect for data when navigating back with data (backport #1680)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Navigation] NavigateBackWithResultAsync processes the result but doesn't navigate back
2 participants