Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Logging for navigation regions #1609

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Jun 30, 2023

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

Minimal logging for navigation regions

What is the new behavior?

Regions are able to generate trace logs

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • [N/A] Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • [N/A] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • [N/A] Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • [N/A] Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph marked this pull request as ready for review July 17, 2023 07:19
@nickrandolph nickrandolph enabled auto-merge July 17, 2023 07:20
@nickrandolph nickrandolph merged commit 341173b into main Jul 28, 2023
@nickrandolph nickrandolph deleted the dev/nr/loggingfornavregion branch July 28, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants