-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding support for custom endpointoptions #1591
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@lukeblevins can you update the http + refit documentation to include this feature. Take a look at the usage in the TestHarness sample for http and refit for an example of how to use this |
nickrandolph
force-pushed
the
dev/nr/issue1590
branch
from
June 28, 2023 06:42
f31e912
to
4b22c9f
Compare
lukeblevins
reviewed
Jul 3, 2023
lukeblevins
reviewed
Jul 3, 2023
lukeblevins
reviewed
Jul 3, 2023
lukeblevins
approved these changes
Jul 3, 2023
nickrandolph
force-pushed
the
dev/nr/issue1590
branch
from
July 4, 2023 05:38
291e1dc
to
786397c
Compare
nickrandolph
force-pushed
the
dev/nr/issue1590
branch
from
July 4, 2023 05:45
786397c
to
90d34b7
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
lukeblevins
force-pushed
the
dev/nr/issue1590
branch
from
July 17, 2023 12:02
2675cac
to
90d34b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes: #1590
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Additional settings for httpclient need to be done through a custom appsettings section
What is the new behavior?
Additional settings for httpclient can be added to existing endpoint section using a sub-class of EndpointOptions to access the information in code
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.