chore: Unifiy implementation of State #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nothing has been updated Currenlty if nothig has changed, it would still remove all IsTransient axes.
State is now only a FeedSubscription holder of an UpdateFeed.
… applying updates
weitzhandler
approved these changes
Jun 27, 2023
|
/azp run |
|
No commit pushedDate could be found for PR 1586 in repo unoplatform/uno.extensions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked #1410
Refactoring
Unify implantation of the
Stateto always be a "subscription on anUpdateFeed" no matter the type of the updates defined on it.What is the current behavior?
When a state was created using
StateUpdateKind.Persistent(only for pagination), it was using a completed (more recent) implementation.What is the new behavior?
No matter the defined
StateUpdateKind,Statenow uses the same implementation (which can be summarized as "a state is aFeedSubscriptionmade on anUpdateFeed")PR Checklist
Screenshots Compare Test Runresults.