Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Mvux): added sample repo for all tutorials #1566

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

roubachof
Copy link
Contributor

@roubachof roubachof commented Jun 15, 2023

added the links to sample repo at the beginning.

Some remarks as well:

Overview

I feel it misses the main point: "how do we ensure we have a coherent state throughout the app?"

Do you ever ended in the situation where you have to pass object between view models?
Did you ever awaited the result of a page to obtain an updated object?
Or even worse...
SEND AN UPDATED OBJECT VIA A MEDIATOR PATTERN TO ALL YOUR VIEW MODELS!
crowd in shock
And how it made you feel?
Bad uh? Like sick to the stomach bad...
Wouldn't it be better to be sure that the state of an object is distributed to all subscribers as soon as it's updated?
Wouldn't it be rad if you didn't have to bother subscribing and unsuscribing to events to do so?

Or maybe I didn't understand what mvux is about :)
It could very well be the case cause I didn't find a sample showcasing this use case...

Feeds.md

// note that a service does not normally hold data
// this example is for demonstration purposes

Why not? The service layer could cache data by using local repositories or even caching it itself if using a repository pattern is overkill.
Also, if we want to have a coherent state dispatched to all our models, it should be stored in the service layer.

@nickrandolph
Copy link
Contributor

Thanks for the awesome feedback! I've extracted the comments from above into a separate issue

@nickrandolph nickrandolph merged commit 04dcbf3 into unoplatform:main Jun 16, 2023
@welcome
Copy link

welcome bot commented Jun 16, 2023

Congrats on your first pull-request! We ❤ the people who are involved in this project, and we’d love to pay it forward by sending you some swag. If you have any feedback (or ideas how to improve Uno as a open-source project) please open a feedback issue.
giphy
Merci beaucoup 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants