Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid setting PrimaryLanguageOverride when starting Localizationservice #1561

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

nickrandolph
Copy link
Contributor

@nickrandolph nickrandolph commented Jun 14, 2023

GitHub Issue (If applicable): fixes #1438, fixes: #1543

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Localization extensions was setting primarylanguageoverride on startup even if culture hasn't been set by user - this was because previously primarylanguageoverride wasn't being persisted by uno

What is the new behavior?

PrimaryLanguageOverride is now only set when culture is changed in Localization

PR Checklist

Please check if your PR fulfills the following requirements:

  • [X ] Tested code with current supported SDKs
  • [N/A ] Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • [ X] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • [X ] Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • [ X] Contains NO breaking changes
  • [X ] Updated the Release Notes
  • [ X] Associated with an issue (GitHub or internal)

@nickrandolph nickrandolph changed the title Dev/nr/issue1438 fix: Avoid setting PrimaryLanguageOverride when starting Localizationservice Jun 14, 2023
@nickrandolph nickrandolph merged commit 24bc74b into main Jun 16, 2023
@nickrandolph nickrandolph deleted the dev/nr/issue1438 branch June 16, 2023 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants