Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing build props for IsIOS #1514

Merged
merged 4 commits into from
Jun 1, 2023
Merged

Fixing build props for IsIOS #1514

merged 4 commits into from
Jun 1, 2023

Conversation

dansiegel
Copy link
Contributor

GitHub Issue (If applicable): #

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

The check for IsIOS includes both iOS & MacCatalyst

What is the new behavior?

The check for IsIOS only includes iOS

Android, iOS, MacCatalyst, MacOS now use netX agnostic check to prevent issues as we update from net6 in the future.

@dansiegel dansiegel requested a review from nickrandolph May 30, 2023 17:25
@dansiegel dansiegel enabled auto-merge May 30, 2023 17:25
@dansiegel dansiegel merged commit 30a6689 into main Jun 1, 2023
@dansiegel dansiegel deleted the dev/ds/ios-props branch June 1, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Props set IsIOS for MacCatalyst
2 participants