Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updating Skia/Wasm target packages to net6 #1477

Merged
merged 2 commits into from
May 19, 2023

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): #1476

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Skia/Wasm target packages are netstandard2.0, meaning that #if NET6 conditional includes aren't valid

What is the new behavior?

Skia/Wasm targets net6.0

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph force-pushed the dev/nr/unologgingfix branch from ce8d0ad to f873b84 Compare May 19, 2023 15:52
@nickrandolph nickrandolph enabled auto-merge May 19, 2023 16:02
@nickrandolph nickrandolph force-pushed the dev/nr/unologgingfix branch from 8e063d1 to ef3749f Compare May 19, 2023 16:06
@nickrandolph nickrandolph merged commit 9be16a0 into main May 19, 2023
@nickrandolph nickrandolph deleted the dev/nr/unologgingfix branch May 19, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants