Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(mvux): MVUX Overview rewrite #1475

Merged
merged 1 commit into from
Jun 5, 2023
Merged

docs(mvux): MVUX Overview rewrite #1475

merged 1 commit into from
Jun 5, 2023

Conversation

weitzhandler
Copy link
Member

PR Type

  • Documentation content changes

PR Checklist

Please check if your PR fulfills the following requirements:

  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Contains NO breaking changes

@weitzhandler weitzhandler requested a review from nickrandolph May 19, 2023 06:41
@weitzhandler weitzhandler self-assigned this May 19, 2023
@weitzhandler weitzhandler force-pushed the dev/shimmy/mvux-overview branch 5 times, most recently from e0dd71c to 00a955a Compare May 23, 2023 13:31
mrlacey
mrlacey suggested changes May 23, 2023
View reviewed changes
Copy link
Contributor

@mrlacey mrlacey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could also do with being passed through a grammar checker. (Grammar issues not flagged by me.)

doc/Overview/Mvux/WIP_Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/WIP_Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/WIP_Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/WIP_Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/WIP_Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/WIP_Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/WIP_Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/WIP_Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/WIP_Overview.md Outdated Show resolved Hide resolved
doc/Overview/Mvux/WIP_Overview.md Outdated Show resolved Hide resolved
@weitzhandler weitzhandler marked this pull request as ready for review June 4, 2023 16:32
@nickrandolph nickrandolph force-pushed the dev/shimmy/mvux-overview branch 4 times, most recently from 14bb455 to 9d8c8de Compare June 5, 2023 07:22
nickrandolph
nickrandolph requested changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@nickrandolph nickrandolph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to squash edits

@nickrandolph @mrlacey @weitzhandler
docs(mvux): Reworking Overview
c878f4c 
Co-authored-by: Matt Lacey <matt@mrlacey.co.uk>
Co-authored-by: Shimmy <2716316+weitzhandler@users.noreply.github.com>
@nickrandolph nickrandolph force-pushed the dev/shimmy/mvux-overview branch from 867d0b5 to c878f4c Compare June 5, 2023 14:31
@nickrandolph nickrandolph enabled auto-merge June 5, 2023 14:34
@nickrandolph nickrandolph merged commit 704a8f2 into main Jun 5, 2023
@nickrandolph nickrandolph deleted the dev/shimmy/mvux-overview branch June 5, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dr1rrb dr1rrb dr1rrb left review comments

@mrlacey mrlacey mrlacey requested changes

@nickrandolph nickrandolph nickrandolph approved these changes

Assignees

@weitzhandler weitzhandler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weitzhandler @mrlacey @nickrandolph @dr1rrb