Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Linker correction for localization #1474

Merged
merged 2 commits into from
May 18, 2023
Merged

Conversation

nickrandolph
Copy link
Contributor

GitHub Issue (If applicable): #1473

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

See issue

What is the new behavior?

Localization works because correct types are added to linker definition

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@nickrandolph nickrandolph enabled auto-merge May 18, 2023 08:31
Co-authored-by: Dan Siegel <me@dansiegel.net>
@nickrandolph nickrandolph merged commit 216f456 into main May 18, 2023
@nickrandolph nickrandolph deleted the dev/nr/localizationfail branch May 18, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants