Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: FeedView loading state #1325

Merged
merged 2 commits into from
Mar 27, 2023
Merged

fix: FeedView loading state #1325

merged 2 commits into from
Mar 27, 2023

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Mar 24, 2023

closes #1150
closes #1318

Bugfix

  1. Loading state of ILoadable disapear earlier than FeedView's loading state
  2. Default FeedView style does not hide the loading state

What is the current behavior?

  1. Default style of the FeedView uses a SmoothVisualStateManager that can defer GoToState to avoid flickers, but when used in conjunction of a LoadingView this cause states to not be sychronized.
  2. The loading presenter is Visible by default

What is the new behavior?

  1. The FeedView can now inform the SmoothVisualStateManager that states should not be deffered for initial loading (if the usage of a LoadingView is detected.
  2. 🙃

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@dr1rrb dr1rrb enabled auto-merge March 24, 2023 20:23
jeromelaban
jeromelaban approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test this new behavior?

jeromelaban
jeromelaban approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test this new behavior?

jeromelaban
jeromelaban approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test this new behavior?

jeromelaban
jeromelaban approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@jeromelaban jeromelaban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test this new behavior?

@dr1rrb dr1rrb merged commit 5180e70 into main Mar 27, 2023
@dr1rrb dr1rrb deleted the dev/dr/feedViewLoadable branch March 27, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@dr1rrb @jeromelaban