Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add proper DefaultFeedViewStyle Key and use it as Implicit #1298

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

agneszitte
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix

Description

Add proper DefaultFeedViewStyle Key to have both an explicit and implicit style.
So in an app, you would be able to base a custom FeedView style on the default without having to repeat everything that's in the default template.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Docs have been added/updated which fit documentation template. (for bug fixes / features)
  • Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Wasm UI Tests are not showing unexpected any differences. Validate PR Screenshots Compare Test Run results.
  • Contains NO breaking changes
  • Updated the Release Notes
  • Associated with an issue (GitHub or internal)

@nickrandolph nickrandolph enabled auto-merge March 20, 2023 13:26
@nickrandolph nickrandolph merged commit b17d443 into main Mar 20, 2023
@nickrandolph nickrandolph deleted the dev/agzi/DefaultFeedViewStyle branch March 20, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants