Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding the missing from on signTypedData #4763

Merged
merged 1 commit into from
Sep 23, 2019
Merged

adding the missing from on signTypedData #4763

merged 1 commit into from
Sep 23, 2019

Conversation

julien51
Copy link
Member

Description

The next version of eth-sig-util adds types which are breaking in #4702
This PR anticipates that so we can merge the package updates.

Checklist:

  • 1 PR, 1 purpose: my Pull Request applies to a single purpose
    • This PR only contains configuration changes (package.json, etc.)
    • This PR only contains code changes (if configuration changes are required, do a separate PR first, then re-base)
  • My code follows the style guidelines of this project, including naming conventions
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • If my code adds or changes components, I have written corresponding stories with Storybook
  • I have performed a self-review of my own code
  • If my code involves visual changes, I am adding applicable screenshots to this thread

@julien51
Copy link
Member Author

PTAL @cnasc @akeem
I have added the updated dep to this branch.

Copy link
Contributor

@cnasc cnasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@julien51 julien51 merged commit 4d7b1e6 into master Sep 23, 2019
@julien51 julien51 deleted the julien-types branch September 23, 2019 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants