-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(cloudflare-kv, cloudflare-r2): move getBindings
to utils and add default BUCKET
for r2
#292
Conversation
β Live Preview ready!
|
(sorry for delay on review. i will do it asap in next days to release ππΌ overall looks nice!) |
getBindings
to utilsgetBindings
to utils
I've been thinking about additional changes lately. There will be more HTTP drivers for Cloudflare in the future. It would be good to put general functions and types in one place:
etc. Creating a new PR at this point seems "problematic" because an identical file would be created as in this PR. So maybe change the title of this request and include generalized http functions for cloudflare here as well? |
@pi0 Can you address my comment above? |
getBindings
to utilsgetBindings
to utils
getBindings
to utilsgetBindings
to utils and add default BUCKET
for r2
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
==========================================
+ Coverage 64.06% 64.26% +0.20%
==========================================
Files 41 42 +1
Lines 4121 4105 -16
Branches 493 490 -3
==========================================
- Hits 2640 2638 -2
+ Misses 1469 1455 -14
Partials 12 12 β View full report in Codecov by Sentry. |
Thanks again! I have made few more refactors to make types working. PR also welcome to prepare types refactoring we might make |
π Linked issue
β Type of change
π Description
The
getBindings
function was used in 2 files. This PR:getBindings
function toutils
binding
value forR2
π Checklist