Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(node:events): rewrite EventEmitter #128

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Aug 8, 2023

->

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Checking a bundle size increase issue with @danielroe, we found out that EventEmitter class (used by HTTP modules) is not side-effect free and when referencing it from h3 (only unused import) bundlers add it to the runtime.

This rewrites the class entirely with modern syntax and smaller code. (there are slight behavior changes but i guess they should be fine)

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@pi0 pi0 requested a review from danielroe August 8, 2023 13:10
@pi0 pi0 force-pushed the refactor/event-emiter branch from 35741ab to 43fa516 Compare August 8, 2023 14:53
@pi0 pi0 merged commit aadb6fe into main Aug 8, 2023
@pi0 pi0 deleted the refactor/event-emiter branch August 8, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants