Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): preserve http number header type with setHeader #119

Merged
merged 4 commits into from
Aug 2, 2023

Conversation

Hebilicious
Copy link
Member

@Hebilicious Hebilicious commented Jul 28, 2023

πŸ”— Linked issue

fix #118

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This PR changes the odd unenv behaviour that joined multiple value headers instead of preserving the array.
This brings setHeader behaviour in line with appendHeader when it comes to multiple values headers.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@Hebilicious Hebilicious requested a review from pi0 July 28, 2023 07:45
@pi0 pi0 changed the title fix: preserve setheader value type fix(node): preserve http response value types with setHeader Aug 2, 2023
@pi0 pi0 changed the title fix(node): preserve http response value types with setHeader fix(node): preserve http number header type with setHeader Aug 2, 2023
@pi0 pi0 merged commit bd09775 into main Aug 2, 2023
@pi0 pi0 deleted the set-header-preserve-value branch August 4, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All response headers are converted to string
2 participants