Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support jsx #200

Merged
merged 5 commits into from
Sep 25, 2024
Merged

feat: support jsx #200

merged 5 commits into from
Sep 25, 2024

Conversation

yuusheng
Copy link
Contributor

@yuusheng yuusheng commented Jan 5, 2024 •
edited
Loading

🔗 Linked issue

#138

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Currently jiti has no jsx support. This PR aims to support jsx with some simple configurations.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@yuusheng yuusheng marked this pull request as ready for review January 5, 2024 19:14
yuusheng
yuusheng commented Jan 5, 2024
View reviewed changes
src/options.ts Outdated Show resolved Hide resolved
@pi0 pi0 changed the title feat(jsx): add basic jsx support for jiti feat: support jsx Jan 10, 2024
pi0
pi0 reviewed Jan 10, 2024
View reviewed changes
src/babel.ts Outdated Show resolved Hide resolved
pi0
pi0 reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
pi0
pi0 reviewed Jan 10, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@yuusheng
Copy link
Contributor Author

Should this PR merge into the main branch? Maybe merge into the v1 branch?

@pi0
Copy link
Member

pi0 commented Jan 10, 2024

main should we fine we shall announce it for v2 👍🏼

@pi0 pi0 force-pushed the feat/jsx(tsx)-support branch from 1343be6 to 8887eb6 Compare September 25, 2024 12:24
@pi0 pi0 merged commit eb06426 into unjs:main Sep 25, 2024
7 checks passed
@yuusheng yuusheng deleted the feat/jsx(tsx)-support branch September 25, 2024 13:32
@pi0 pi0 mentioned this pull request Sep 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yuusheng @pi0