Skip to content

feat: add libsql support #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 21, 2023
Merged

feat: add libsql support #25

merged 7 commits into from
Jul 21, 2023

Conversation

Hebilicious
Copy link
Member

@Hebilicious Hebilicious commented Jul 3, 2023

πŸ”— Linked issue

#14

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Resolves #14

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

*
* https://github.com/libsql/libsql-client-ts#supported-urls
*/
url: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please rewrite it in markdown? instead of ts syntax for readability)

Copy link
Member Author

@Hebilicious Hebilicious Jul 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was literally doing this now

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@pi0 pi0 merged commit 77b6093 into main Jul 21, 2023
@pi0 pi0 deleted the libsql branch July 21, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libsql connector
2 participants