Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Install Poetry link to instructions for installation #257

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

jordandsullivan
Copy link
Collaborator

Previous link was to general Poetry website

Previous link was to general Poetry website
Copy link
Collaborator

@Misty-W Misty-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -27,7 +27,7 @@ By leveraging [qBraid](https://github.com/qBraid/qBraid), UCC interfaces automat
pip install ucc
```

If developing or running benchmark, please install [Poetry](https://python-poetry.org/), then setup a dev version:
If developing or running benchmark, please install [Poetry](https://github.com/python-poetry/install.python-poetry.org), then setup a dev version:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well

Suggested change
If developing or running benchmark, please install [Poetry](https://github.com/python-poetry/install.python-poetry.org), then setup a dev version:
If developing or running benchmarks, please install [Poetry](https://github.com/python-poetry/install.python-poetry.org), then setup a dev version:

Copy link
Collaborator

@bachase bachase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Only consideration is if https://python-poetry.org/docs/#installation would be a better link. But no strong opinion

@jordandsullivan
Copy link
Collaborator Author

Yeah I think I'll stick with the curl version for now since it was fewer install steps on my machine.

@jordandsullivan jordandsullivan merged commit c22e0a7 into main Feb 25, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants