Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom transpilation passes #256

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Conversation

bachase
Copy link
Collaborator

@bachase bachase commented Feb 25, 2025

As part of #246, the team benchmarked the impact of the customized transpilation passes compared with the version of the equivalent passes in the latest version of Qiskit. The results show the customizations are not currently providing additional gate savings or compilation time improvements compared with the native Qiskit passes.

This PR removes these customized passes and replaces them with the Qiskit equivalents in the default set in UCCDefault1.

@jordandsullivan
Copy link
Collaborator

jordandsullivan commented Feb 26, 2025

I just manually triggered a benchmark run to check performance, and it looks good: same gate reduction and faster runtime. Although we are no longer focused on the narrative of being "the best compiler," this change actually brings us to be the top performing compiler in terms of speed and compiled ratio for our benchmarks :)
https://github.com/unitaryfund/ucc/blob/6c2c00ca9a7680275decda2dce30878241accd18/benchmarks/avg_compiler_benchmarks_over_time.png

Also, perhaps we should consider adding the Run benchmarks step as an automatic step in PRs -- only reason I didn't was that I didn't want them to run every time code was pushed to an open PR, plus it can create annoying merge conflicts when replacing the .pngs.

Copy link
Collaborator

@jordandsullivan jordandsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this investigation and finding that we can get this speedup by using the latest Qiskit versions of our UCC pass set.

@bachase
Copy link
Collaborator Author

bachase commented Feb 26, 2025

Thanks!

I agree on having these run as part of PRs. I think I've got a suggestion on how to do it without causing the conflicts, but need to write it down to validate in #235. Hoping to get my thoughts in markdown this week/next at the latest.

@bachase bachase force-pushed the 246-remove-custom-transpilers branch from 6c2c00c to a98e474 Compare February 26, 2025 21:33
@bachase bachase merged commit ec608cd into main Feb 26, 2025
4 checks passed
@bachase bachase deleted the 246-remove-custom-transpilers branch February 26, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants