Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EVM - Ensure correct commitment channel is used on packet lifecycle #3110

Closed
hussein-aitlahcen opened this issue Oct 16, 2024 · 0 comments · Fixed by #3113
Closed

EVM - Ensure correct commitment channel is used on packet lifecycle #3110

hussein-aitlahcen opened this issue Oct 16, 2024 · 0 comments · Fixed by #3113
Assignees
@hussein-aitlahcen

Comments

@hussein-aitlahcen
Copy link
Contributor

I noticed we use a wrong channel end when checking the commitment on the recvPacket side. We must double check all of them and ensure their correctness.
@hussein-aitlahcen hussein-aitlahcen self-assigned this Oct 16, 2024
@hussein-aitlahcen hussein-aitlahcen mentioned this issue Oct 17, 2024
Merged
hussein-aitlahcen added a commit that referenced this issue Oct 17, 2024
@hussein-aitlahcen
feat(evm): fix commitment & more test variants (#3113)
7dc46b2 
- fixup `recvPacket` proof commitment key
- add more test variants for gas comparison

fixes #3110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hussein-aitlahcen hussein-aitlahcen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(evm): fix commitment & more test variants unionlabs/union
1 participant
@hussein-aitlahcen