Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception on older browsers #246

Merged
merged 9 commits into from
Jun 19, 2024
Merged

Fix exception on older browsers #246

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a6003b8
Check configurable when defining property
justinbhopper Jun 5, 2024
6433d85
Fix formatting
justinbhopper Jun 6, 2024
8525da9
Add tests for CallableInstance
justinbhopper Jun 6, 2024
244a130
Restore type coverage to test files
justinbhopper Jun 11, 2024
25ae3e2
Add type coverage to callable instance
justinbhopper Jun 11, 2024
de3a4dd
Replace ts-ignore with ts-expect-error
justinbhopper Jun 11, 2024
dbc4e74
Only skip non-configurable fields of target object
justinbhopper Jun 17, 2024
26244e6
Remove configurable check and skip property cloning
justinbhopper Jun 18, 2024
c725d6c
Remove unneeded test for CallableInstance
justinbhopper Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions lib/callable-instance.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,17 @@ export const CallableInstance =

Object.setPrototypeOf(apply, proto)

const names = Object.getOwnPropertyNames(value)

for (const p of names) {
const descriptor = Object.getOwnPropertyDescriptor(value, p)
if (descriptor) Object.defineProperty(apply, p, descriptor)
}
// Not needed for us in `unified`: we only call this on the `copy`
// function,
// and we don't need to add its fields (`length`, `name`)
// over.
// See also: GH-246.
// const names = Object.getOwnPropertyNames(value)
//
// for (const p of names) {
// const descriptor = Object.getOwnPropertyDescriptor(value, p)
// if (descriptor) Object.defineProperty(apply, p, descriptor)
// }

return apply
}
Expand Down
Loading