Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: add support for buffer, other return values #144

Merged
merged 1 commit into from
Jul 4, 2021
Merged

types: add support for buffer, other return values #144

merged 1 commit into from
Jul 4, 2021

Conversation

wooorm
Copy link
Member

@wooorm wooorm commented Jul 4, 2021

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Buffers, null/undefined, and unknown were not allowed from compilers.
While string is most often used as a return value, the other values should be allowed too

@wooorm wooorm added the ☂️ area/types This affects typings label Jul 4, 2021
@codecov-commenter

This comment has been minimized.

Sign in to view
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jul 4, 2021
@wooorm wooorm merged commit b22bf8e into main Jul 4, 2021
@wooorm wooorm deleted the compiler-yields branch July 4, 2021 16:06
@github-actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added the 💪 phase/solved Post is done label Jul 4, 2021
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees
No one assigned
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wooorm @codecov-commenter @ChristianMurphy