Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CI checks #93

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Conversation

Jules-Bertholet
Copy link
Contributor

Splits out "unrelated" changes from #92 as requested.

  • Check formatting
  • Check clippy
  • Check MSRV
  • Check docs

@Manishearth
Copy link
Member

This is still a lot of changes all in one commit.

Please split it up further, it can be in one PR but it should be reviewably split into multiple commits, that have descriptive commit messages when they're making nontrivial changes.

Where are all the extra tests coming from? What's with all of the changes to the python script? Some seem to be python formatting (fine), others actually change the structure/behavior of the code?

@Jules-Bertholet
Copy link
Contributor Author

The changes to the Python script are to ensure that the Rust code files it outputs pass rustfmt. I didn't make any changes to how the normalization tests are generated; I just regenerated the file, which was outdated before (as not checked by CI).

@Jules-Bertholet
Copy link
Contributor Author

I've split the PR into four commits.

@Manishearth
Copy link
Member

@Jules-Bertholet okay, can you remove the Python changes? Let's have #[rustfmt::skip] on the generated file for now. Perhaps save those changes for a separate PR, I'd like to have a closer look at that and I don't want to block this on that.

@Jules-Bertholet
Copy link
Contributor Author

can you remove the Python changes?

Done

And also mass-reformat.
`tables.rs` is ignored for now
@Manishearth
Copy link
Member

CI fails

error: the item `FnMut` is imported redundantly
  --> src/normalize.rs:17:18
   |
17 | use core::{char, ops::FnMut};
   |                  ^^^^^^^^^^
  --> /rustc/c475e[23](https://github.com/unicode-rs/unicode-normalization/actions/runs/8099597628/job/22136519907?pr=93#step:4:24)03b551d726307c646181e0677af1e0069/library/std/src/prelude/mod.rs:115:13
   |
   = note: the item `FnMut` is already defined here
   |
   = note: `-D unused-imports` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(unused_imports)]`

Looks like nightly Rust expanded its unused import warnings…
@Manishearth Manishearth merged commit a6a221a into unicode-rs:master Feb 29, 2024
5 checks passed
@Jules-Bertholet Jules-Bertholet deleted the more-ci-checks branch February 29, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants