Split addition comparisons #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed in the PAG meeting of 2024-09-12; I need to do this sooner rather than later, for now I only have 12 of those tests in flight, but this is growing rapidly.
Also make it explicit which characters are having their properties tested and which ones are just property values in the Propertywise/CorrespondTo tests (this makes it much easier to test numerals, since I can then use ASCII digits as value-only « ⧴ » counterparts for Numeric_Value.
This should also make it nicer to check coverage; for some of those tests it can be unclear whether there are gaps of characters whose properties are not tested; in such cases one could have some sort of declaration that « this tests the properties of U+XXXX...U+YYYY » at the top of the file, and it would be easy to check that all those characters show up in a Propertywise/AreAlike test or before the first ⧴ in a Propertywise/CorrespondTo test.