Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the icu crate to no_std #911

Merged
merged 11 commits into from
Jul 27, 2021
Merged

Conversation

Manishearth
Copy link
Member

This fixes #812 and gates CI on it building for no-std. Further dependencies being pulled into icu will have to support no_std (or be conditional on the "std" feature)

cc @nciric

@Manishearth Manishearth requested review from echeran, sffc, zbraniecki and a team as code owners July 27, 2021 21:27
@coveralls
Copy link

Pull Request Test Coverage Report for Build 143beae85b82774086c0452323a395638eb87798-PR-911

  • 4 of 9 (44.44%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 74.42%

Changes Missing Coverage Covered Lines Changed/Added Lines %
components/datetime/src/error.rs 1 2 50.0%
components/datetime/src/date.rs 1 3 33.33%
components/datetime/src/skeleton.rs 1 3 33.33%
Files with Coverage Reduction New Missed Lines %
components/datetime/src/fields/symbols.rs 1 69.35%
Totals Coverage Status
Change from base Build e97c8c3b3d9c129bbf63ffc8162080dd01931ee1: 0.0%
Covered Lines: 9310
Relevant Lines: 12510

💛 - Coveralls

Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm impressed that this works fairly painlessly!

@Manishearth Manishearth merged commit cd4b7c5 into unicode-org:main Jul 27, 2021
@Manishearth Manishearth deleted the more-no-std branch February 3, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisiting no_std in ICU4X
3 participants