-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add caching for the rest of the islamic calendars (عید مبارک!!) #4785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
41c7a1d
to
8187d3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much improved; yeah, let's only use the precompiled data solution when we have astonomy going on. The formulas implementing islamic-tbla
and islamic-civil
are very straightforward.
Thought: I wonder if we could make islamic-umalqura
and islamic
fall back to one of the formulaic calendars for distant dates instead of carrying around the astronomy code at runtime.
d4965e6
to
c0186ad
Compare
7003831
to
1ce5959
Compare
|
1ce5959
to
b64d374
Compare
Fixes #3933
Uses work from #4770 on the remaining 3 calendars
عید مبارک!!