Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call to rounding function in fixeddecimal tiny #4586

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

sffc
Copy link
Member

@sffc sffc commented Feb 5, 2024

For testing the impact of #4578

@sffc sffc requested a review from a team as a code owner February 5, 2024 23:46
@sffc
Copy link
Member Author

sffc commented Feb 6, 2024

Main:

-rwxr-xr-x 1 root root    24248 Feb  5 23:27 optim4.elf
-rwxr-xr-x 1 root root    13520 Feb  5 23:27 optim5.elf

This branch:

-rwxr-xr-x 1 root root    25568 Feb  5 23:55 optim4.elf
-rwxr-xr-x 1 root root    14464 Feb  5 23:55 optim5.elf

Seems approximately reasonable; about 1 kB for the rounding function. Would like it to be smaller but at least it is not bigger.

@sffc sffc requested a review from Manishearth February 6, 2024 00:52
@sffc sffc merged commit a0e18a3 into main Feb 6, 2024
42 checks passed
@sffc sffc deleted the sffc-patch-2 branch February 6, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants