Baked data for icu_properties
#3565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Jun 22, 2023
12a4d57 to
d21011b
Compare
|
(squash) |
This was referenced Jun 22, 2023
Manishearth
previously approved these changes
Jun 22, 2023
sffc
reviewed
Jun 22, 2023
|
I'd really prefer to do the name bikeshedding later as this blocks other PRs. |
|
(I am ok with this landing as-is with all the comments considered for followup) |
7d5b26c to
bc09292
Compare
bc09292 to
9c7be5b
Compare
Manishearth
previously approved these changes
Jun 26, 2023
Manishearth
approved these changes
Jun 26, 2023
sffc
approved these changes
Jun 26, 2023
Comment on lines
+26
to
+27
| //! assert!(sets::emoji().contains('🎃')); // U+1F383 JACK-O-LANTERN | ||
| //! assert!(!sets::emoji().contains('木')); // U+6728 |
There was a problem hiding this comment.
Nit, here and elsewhere (optional): I have a slight preference for keeping the intermediate object stored in its own variable since it is closer to what the code looks like if you use the explicit data provider version of it
|
Force-merging because FFI CI is not working right now (let's see if it works on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2945
Fixes #3565
This is not release-polished, but is currently blocking segmenter, collator, and normalizer baked data, so let's bikeshed names and docs later. Potentially relevant: #2856 (comment)