Fix CI clippy check by removing caching #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 28d04d0de48bd3f9151ce26560a8e5f6c754bee2-PR-179
💛 - Coveralls |
|
Should we cache the "registry" and "index", and only un-cache the "build"? |
|
Even before the caching config was fixed, I don't recall the "registry" and "index" steps taking that long -- it was always the build step that took long because of the need to download and compile deps (example from before caching was fixed). They usually take 1s - 6s. I'm okay with not changing things to partially cache to keep things less complicated with little wall clock time impact. |
sffc
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the CI clippy action. Lost in the iterations on the original clippy PR (#161) was the fact that we don't want to include the cache step in the clippy action since it restores code from cache that subsequently gets picked up by cargo.
I did some local testing, then verified by testing using a draft PR (#178) to test for real, and the fix works to address the original problem of clippy errors on non-existent code.
What should remain in the clippy output for the PR in question (#141) after this fix are the real clippy errors on the actual existing code of that PR.