Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-20804 OOM not handled in selectForMask #811

Merged
merged 1 commit into from
Sep 12, 2019
Merged

ICU-20804 OOM not handled in selectForMask #811

merged 1 commit into from
Sep 12, 2019

Conversation

jefgen
Copy link
Member

@jefgen jefgen commented Sep 4, 2019 •
edited
Loading

Checklist

daniel-ju
daniel-ju previously approved these changes Sep 4, 2019
View reviewed changes
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • icu4c/source/common/ucnvsel.cpp is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@jefgen jefgen changed the base branch from master to maint/maint-65 September 11, 2019 17:09
@jefgen jefgen requested a review from markusicu September 11, 2019 17:09
@jefgen
Copy link
Member Author

jefgen commented Sep 11, 2019

Note: I changed the target branch on this PR to maint/maint-65.

markusicu
markusicu approved these changes Sep 11, 2019
View reviewed changes
Copy link
Member

@markusicu markusicu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jefgen jefgen merged commit 5464f34 into unicode-org:maint/maint-65 Sep 12, 2019
@jefgen jefgen deleted the jefgen/ICU-20804 branch September 12, 2019 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu markusicu approved these changes

@axelandrejs axelandrejs axelandrejs approved these changes

@daniel-ju daniel-ju daniel-ju approved these changes

Assignees

@daniel-ju daniel-ju

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jefgen @markusicu @axelandrejs @daniel-ju