ICU-20493 Warn on global/static c’tors #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting on some resolution for the failing Azure CI builds... |
|
The failing MSYS2 builds are due to an update to MSYS that was released, which causes the I have a fix in PR #711 which resolves the issue. This was recently merged to master and the CI builds are now back to a working state. If this PR could be rebased on the latest changes from master, then I suspect that the failing CI builds should hopefully be fixed. :) |
|
Ok. Will do
|
- add -Wglobal-constructors to clang (only for libs) - Note: ignore 'runstatedir' flap in configure
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
|
In the PR text, "Note: ignore 'runstatedir' flap in configure" did you mean s/flap/flag/ ? |
aheninger
approved these changes
Jul 26, 2019
|
Flap. An unreleased autoconf version keeps adding stuff, when I use the
latest release it removes it. So it flaps back and forth.
El jue., 25 de jul. de 2019 2:51 p. m., Markus Scherer <
notifications@github.com> escribió:
… In the PR text, "Note: ignore 'runstatedir' flap in configure" did you
mean s/flap/flag/ ?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#708?email_source=notifications&email_token=AAGQZM5OK6LKFRJK25MXLH3QBIN5RA5CNFSM4IFM6IQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD224FWI#issuecomment-515228377>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGQZM5YVFPTT5XVJLU7WC3QBIN5RANCNFSM4IFM6IQQ>
.
|
|
I know "flip-flop" but "flap" is new to me :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICU-20493