ICU-21140 Make UTF-8 explicit for all file access. #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hagbard
commented
Jun 2, 2020
| @@ -274,7 +275,7 @@ private static void checkBuild(boolean condition, String message, Object... args | |||
|
|
|||
| private static ImmutableList<String> readLinesFromResource(String name) { | |||
| try (InputStream in = CleanOutputDirectoryTask.class.getResourceAsStream(name)) { | |||
| return ImmutableList.copyOf(CharStreams.readLines(new InputStreamReader(in))); | |||
There was a problem hiding this comment.
This was the one place that actually needed it, the rest of the changes are "no ops" but I think improve readability.
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
daniel-ju
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found one more case where UTF-8 had to be specified and I made it explicit in all the remaining file accesses I could find. While I'm glad UTF-8 is default in Files.newBufferedReader(), the fact that Java has for so many years assumed that "no charset" implies "system default" means the people reading the code are potentially going to be confused if it's omitted, so I just added it consistently everywhere.
Checklist